feat(roadmap): 완료 콜백을 result 포함 /roadmap/complete로 전송#88
Closed
Youcu wants to merge 1 commit into
Closed
Conversation
로드맵은 PDF가 없어 공용 notify_be(/api/v1/ai/jobs/complete)로는 status가 항상
ERROR가 되고 평가 result도 BE에 전달되지 않았다. BE가 결과를 받아 FE로 흘릴 수 있게
로드맵 전용 콜백을 추가한다:
- webhook.notify_be_roadmap(ai_job_id, status, result, error_message)
→ POST {BE}/api/v1/ai/roadmap/complete (X-INTERNAL-API-KEY 동일)
- run_assess_task finally: 성공 시 status=DONE+result, 실패 시 ERROR+error_message로
notify_be_roadmap 호출(공용 notify_be 대신).
공용 notify_be(포폴/자소서 PDF 경로)는 그대로 유지. BE는 completeRoadmapJob에서
result를 result_json으로 저장 후 SSE/폴링으로 FE에 전달.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
로드맵 완료 콜백이 포폴/자소서용 공용
notify_be(POST /api/v1/ai/jobs/complete)를 쓰고 있어:status가 항상 ERROR로 전송됨(공용 로직:status="DONE" if output_pdf_url else "ERROR").→ BE가 로드맵 결과를 받아 FE로 흘릴 수 없었음(BE↔FE는 relay 정합 완료, 이 콜백만 비어 있던 상태).
변경
webhook.notify_be_roadmap(ai_job_id, status, result, error_message)추가 →POST {BE}/api/v1/ai/roadmap/complete(헤더X-INTERNAL-API-KEY동일).run_assess_taskfinally: 성공 시status=DONE+result, 실패 시ERROR+error_message로notify_be_roadmap호출(공용notify_be대신).notify_be(PDF 파이프라인용)는 그대로 유지 — 변경 없음.BE는
/roadmap/complete(completeRoadmapJob)에서 result를result_json으로 저장 후 SSE/폴링으로 FE에 전달(BE/FE PR과 짝).검증
python -m py_compile통과(문법). 공용notify_be는pdf_pipeline에서 계속 사용 — 무영향.비고
main으로 두었습니다. 팀 flow가develop우선이면 retarget 해주세요.result는 merge=false면 평가 배열, merge=true면 단건 배열로 전달(기존 result 구조 그대로).🤖 Generated with Claude Code